Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to polkadot v1.6.0 and depend on fellowship/runtimes #213

Merged
merged 9 commits into from
Feb 22, 2024

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Feb 21, 2024

pardon the monolithic PR, but it would have been extra futile work to migrate the runtimes too before deleting them (and deleting them first wouldn't work because sdk version mismatch with fellows runtimes)

@brenzi brenzi changed the title Ab/polkadot v1.6.0 upgrade to polkadot v1.6.0 and depend on fellowship/runtimes Feb 21, 2024
@brenzi brenzi requested a review from clangenb February 21, 2024 14:14
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I agree that the monolith was probably worth the trade-off this time, but the changes are quite straight forward anyhow IMO.

@brenzi brenzi merged commit e35ee1e into master Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants